Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ass to ass3d #310

Closed
wants to merge 212 commits into from

Conversation

Projects
None yet
8 participants
@SubJunk
Copy link
Member

commented May 9, 2014

3D subtitle conversion by valib

@SubJunk

This comment has been minimized.

Copy link
Member

commented on 2414417 Dec 26, 2013

Is this for 2D-to-3D conversion, or for converting one 3D format to another one?

This comment has been minimized.

Copy link
Contributor Author

replied Dec 26, 2013

It converts one 3D format to another but is CPU demanding and realy working on FFMpeg. It needs testing if it can convert video on the fly and is worth to continue with it.

This comment has been minimized.

Copy link
Member

replied Dec 26, 2013

That's pretty cool. I'll do some testing tomorrow if I find time, I'm sure we are all busy with holidays anyway

@ExSport

This comment has been minimized.

Copy link
Contributor

commented on 028914a Aug 6, 2014

@SubJunk , @valib
Hi Subjunk. I don't know as your TV but my two Panasonic TVs and also TV from Valib support srt and sub subtitles also in case Panasonic site doesn't advertise this support. Only limitation is that external subs works with avi/divx files only, not with other containers.

This comment has been minimized.

Copy link
Member Author

replied Aug 7, 2014

@ExSport I haven't tried it with avi or divx files, that's a shame because it still means those TVs don't have full support for those subtitles

@SubJunk

This comment has been minimized.

Copy link
Member Author

commented on b85de13 Aug 6, 2014

The manual declares support for MP4 but I couldn't get it to work with any codecs, weird.

@SubJunk

This comment has been minimized.

Copy link
Member

commented on 2e1f6a0 Aug 6, 2014

Nice one, thanks!

SubJunk and others added some commits Aug 6, 2014

Added leroy to the thanks for translation contributions list
He has been contributing great Dutch translations since 2012
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/java/net/pms/formats/v2/SubtitleUtils.java
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/java/net/pms/encoders/FFMpegVideo.java
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/java/net/pms/configuration/RendererConfiguration.java
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/external-resources/renderers/PS3.conf
	src/main/java/net/pms/newgui/TranscodingTab.java
	src/main/resources/i18n/messages.properties
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/external-resources/renderers/PS3.conf
	src/main/java/net/pms/encoders/FFMpegVideo.java
Merge branch 'master' into convert_ASS_to_ASS3D
Conflicts:
	src/main/java/net/pms/encoders/MEncoderVideo.java
@ler0y

This comment has been minimized.

Copy link
Contributor

commented on 17e8a1d Aug 10, 2014

Thank you!
I try to support this project where I can :)

This comment has been minimized.

Copy link
Member Author

replied Aug 11, 2014

@ler0y Do you prefer leroy or ler0y for the list?

This comment has been minimized.

Copy link
Contributor

replied Aug 11, 2014

@SubJunk: leroy is fine by me.
I use it already for a long time on the PMS and UMS forum.
Dumb action of mine in the past.. to choose such a commonly used name that of course already was used on Github..

@SubJunk

This comment has been minimized.

Copy link
Member

commented on 202a212 Sep 22, 2014

@valib this commit seems to have caused the main instability with our implementation of FFmpeg subtitles.
It seems that in 4.0.1 it was stable and always used the .ass conversion, but from 4.0.2 onwards it can use the new "-vf subtitles=input.mkv:si=0" syntax which is what seems to cause timeouts for users sometimes.

It might be a bug in FFmpeg itself, I'm not sure.

Maybe we should remove support for that "si" syntax for now?

This comment has been minimized.

Copy link
Contributor Author

replied Sep 22, 2014

@SubJunk It is stable for me but I don't insist on it. We can simply revert this commit and wait until FFmpeg implements subs support completely e.g. add fontconfig, seek support etc. like in Mencoder.

This comment has been minimized.

Copy link
Member

replied Sep 23, 2014

@valib it works for me most of the time. Today I tested it and it worked 5/6 times, but the other way worked 6/6.
It would be great if you can remove the "si=" part safely since you understand this part of the code better than me.

This comment has been minimized.

Copy link
Contributor Author

replied Sep 23, 2014

@SubJunk no problem I will do it.

@valib valib closed this Oct 2, 2014

@valib

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2014

This version cannot be merged. I will rewrite it and open the new pull request

@valib valib deleted the convert_ASS_to_ASS3D branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.