-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🟢 Unleash v6 #4380
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
unleash/src/lib/middleware/rbac-middleware.ts Lines 73 to 92 in 9683dda
|
Removing |
docs on upgrading from v5 to v6, changes needed, breaking things, etc. |
Should we consider consolidating all migration files into a single file? We have 276 migrations. We could do a fresh DB dump after all migrations to start fresh |
What would be the gain? (Assume positive intentions, I'm curious, I'm not trying to be negative here) |
If I'm reading the original comment correctly, we'd squash all the migrations into a single SQL script which would give us the opportunity to avoid some of those dangerous migrations that need to be done in phases I do agree though, this sounds like it'd cause more pain than happiness |
Asking the right questions! I was looking for performance gains. Gathering some data... In my local machine.
This also impacts on test execution speed. I ran Test Suites: 2 failed, 301 passed, 303 total
Tests: 2 failed, 2 skipped, 2786 passed, 2790 total
Snapshots: 103 passed, 103 total
Time: 199.772 s, estimated 203 s And I logged up migration times:
The issue is that the dump is not that great for migrations and without taking into account the failures I also didn't see a performance boost: Test Suites: 34 failed, 269 passed, 303 total
Tests: 126 failed, 2 skipped, 2662 passed, 2790 total
Snapshots: 101 passed, 101 total
Time: 190.593 s, estimated 199 s |
Support for in-memory mode would be great. Our use case would be to run the container in short lived isolated scenarios (e.g. integration testing, running apps locally, CI) and not having to also run Postgres as part of this would make the experience "lighter". |
@chriswk I think we need to support at least v13 for another year. We have a few larger enterprises still stuck on that version. |
You can run https://github.com/Unleash/unleash-edge in offline mode to support that use case. |
I would love to see ESM support 🥳 |
This PR is part of #4380 - Remove legacy `/api/feature` endpoint. ## About the changes ### Frontend - Removes the useFeatures hook - Removes the part of StrategyView that displays features using this strategy (not been working since v4.4) - Removes 2 unused features entries from routes ### Backend - Removes the /api/admin/features endpoint - Moves a couple of non-feature related tests (auth etc) to use /admin/projects endpoint instead - Removes a test that was directly related to the removed endpoint - Moves a couple of tests to the projects/features endpoint - Reworks some tests to fetch features from projects features endpoint and strategies from project strategies
In preparation for v6, this PR removes usage and references to `error.description` instead favoring `error.message` (as mentioned #4380) I found no references in the front end, so this might be (I believe it to be) all the required changes.
Has been removed. We've pretty good at trimming out unused stuff that's easy to remove |
## About the changes This include some notes about the migration guide based on #4380 Initially, we don't expect any breaking change provided users are not using deprecated functionality and your Postgress is in one of the supported versions --------- Co-authored-by: Ivar Conradi Østhus <ivar@getunleash.io> Co-authored-by: sjaanus <sellinjaanus@gmail.com> Co-authored-by: Thomas Heartman <thomas@getunleash.io> Co-authored-by: Nuno Góis <github@nunogois.com>
Decided:
- Node20 #7095
/edge/metrics
endpoint @chriswkmessage
property (removing thedescription
property) @thomasheartmanTodo:
Dropped (did not make it for the v6 plans)
id
column in thepermissions
table (this is an internal db change).Background
A major version is an opportunity to remove deprecated features and add new features to our deprecation list.
The text was updated successfully, but these errors were encountered: