SingleStore v2 API source connector #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Cornell
requested review from
MKhalusova,
ninalopatina,
potter-potter and
rbiseck3
MKhalusova
approved these changes
Oct 30, 2024
Collaborator
MKhalusova
left a comment
MKhalusova
left a comment
There was a problem hiding this comment.
Looks good, though I don't understand the point of this connector.
"The table’s schema must match the schema of the documents that Unstructured produces." - are we moving the json from one place to another? is it an automation use case?
…y to destination connector
Collaborator
Author
|
Good point. I refactored out content about the SingleStore schema to apply only to the destination connector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: