Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
NaCl SDK downloaded from centralized source in CMake #306
The NaCl SDK which is necessary for compiling parts of the gamelogic gets downloaded as a binary package from a single server (currently unvanquished.net) by CMake.
This has a few drawbacks:
My proposal is to add different CMake options for retreiving the dependency. Possible options are:
From a packaging perspective, the SDK needs to be separate, so the first option is preferred, followed by use of a git submodule; regardless, we need to allow for use of separately-installed binaries. Whichever options we allow, allowing download of binaries should be retained as a matter of convenience.
Including the SDK code in our main repository is a bad idea. It needs to be separate and, ideally, minimal – I see no point in building it every time I do a build. I do builds for two architectures for several OS releases each month, so it rapidly becomes a large compile job; I'd rather build exactly what we need and do so less often.