sensor_player entity is broken (currently maps must stick on deprecated definitions instead)

[illwieckz]

Hi, as revealed in this thread, only the deprecated entity code work.

Since 2014-04-30 sensor_player is known to not fire since it's written in a comment in this code here and I can reproduce this bug today.

This file references the obsolete code, and if I replace entity code like trigger_multiple by the new one sensor_player, the map logic (door opening for example) is broken.

[illwieckz]

As seen in #664, this new entity code is not used by official maps, so new code is dead code, which is not good at all.

[Viech]

If you could help us to port the new maps we (you?) could remove the deprecated code and we could find and fix the remaining bugs. 😀

To be honest in the last map upgrade batch I coordinated I didn't have the energy left to also include the entities. We really owe this to @t4im though.

[t4im]

It's probably just a slip in https://github.com/Unvanquished/Unvanquished/blob/master/src/gamelogic/sgame/sg_spawn_sensor.cpp#L492
Can't test it atm, but looks like that should be qtrue

[Viech]

Omg you live! :3

[illwieckz]

yes, qtrue on this line fix many issues, but I have one remaining bug in pulse map. When I touch the texture to trigger the main door opening, the opening sound is heard, but the door does not open…

[Kangz]

@t4im we have C++ in the gamelogic now :3

[illwieckz]

The main door opening bug in pulse is probably related to the “wait” keyword.