all official maps use deprecated entities definitions (so non-deprecated code is dead code) #664
Comments
illwieckz
changed the title
DolceTriade
added
A-Assets
|
See my comment in #663. |
|
Most of these could probably be fixed automatically by script (or something like chameleon), if that is still wanted. I'm not sure how map editor support is these days. I remember that treatment of a few identifiers were hardcoded there; that renaming could be reverted. Generally there won't be any hard feelings if you'd prefer the old names in any cases. |
|
Yes, this is not hart to fix, and script is already written, with a ready to use profile to drive the conversion. In all case the resultant behavior be checked by hand if it works since unused code is dead code and maybe there is issues we don't know and have to fix. For reference, as an exercise I did the changes on the pulse map and that broke the special door opening mechanism, so we know that newer entity definitions are not on par with older ones, by mistake or by design we don't know yet. |
|
I believe this is not an unvanquished issue, but issues with the maps themselves (that is, the bug should be reported against the maps, not against this repo, but I understand that there's lot of maps and this is tedious. Maybe it should be considered an issue with the tooling, too? No idea). |
|
Actually, is it still true? I think I've never seen those warnings on official maps? |
Oh, it's actually true, but the warnings are kinda drowned in the logs. "that renaming could be reverted." yes, this is what should be done, as it is not likely that a proper conversion tool from tremulous to unvanquished will even be done. Those loads of warnings also make it needlessly complicated to debug regressions which were introduced by those renamings, such as:
And possibly other stuff I forgot. Adding noise to the logs is only hurtful as it prevents seeing the real problems. As a matter of fact, I wasted several hours today digging into daemon's shader parser code just because I didn't noticed the problem actually came from warnings saying stuff were removed (because of a regression). |
Hi, all official maps use deprecated entities definitions, so #663 will never be fixed if official maps are not fixed!
antares
chasm
forlorn
parpax
perseus
plat23
spacetracks
station15
thunder
yocto
The text was updated successfully, but these errors were encountered: