Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infuriating Grey Line #858

Closed
DolceTriade opened this issue Dec 19, 2015 · 15 comments · Fixed by DaemonEngine/Daemon#287
Closed

Infuriating Grey Line #858

DolceTriade opened this issue Dec 19, 2015 · 15 comments · Fixed by DaemonEngine/Daemon#287

Comments

@DolceTriade
Copy link
Member

@DolceTriade DolceTriade commented Dec 19, 2015

bug

It goes up the entire screen. It can be hidden behind geometry. I have confirmed that it is not being drawn by libRocket and am unsure about how to test it further.

@Viech

This comment has been minimized.

Copy link
Member

@Viech Viech commented Dec 19, 2015

Can you describe your feelings towards that line in more detail? Why does it make you angry?

Have you considered that it's an hardware issue?

@DolceTriade

This comment has been minimized.

Copy link
Member Author

@DolceTriade DolceTriade commented Dec 19, 2015

It makes me angry because its annoying :( It is most likely a hardware issue. I could not see it using my Intel drivers, but it shows up when I use bumblebee.

@cu-kai

This comment has been minimized.

Copy link
Contributor

@cu-kai cu-kai commented Dec 19, 2015

I get this too, it appears to be related to ssao.

@Viech Viech added the S-Verified label Dec 19, 2015
@Kangz

This comment has been minimized.

Copy link
Member

@Kangz Kangz commented Dec 25, 2015

I don't see a problem in this picture :S

@Viech

This comment has been minimized.

Copy link
Member

@Viech Viech commented Dec 26, 2015

It's hard to verify given image compression artifacts, but raising contrast in the image may help you spot the slightly darker line on the dark grey surface marked with the red rectangle.

@jaytersen

This comment has been minimized.

Copy link
Contributor

@jaytersen jaytersen commented May 1, 2016

I've been doing a little digging on this one and come to the conclusion that this is a more general problem. If i turn ssao off, i can see an extremely faint discontinuity extending vertically down where the line used to be. It is almost as if a few "columns of pixels" are missing/skipped in the final rendered image. This also appears in the depth buffer which i believe is the reason we are getting some occlusion there.

@DolceTriade

This comment has been minimized.

Copy link
Member Author

@DolceTriade DolceTriade commented May 1, 2016

Interesting. So the issue is deep in the renderer?

@jaytersen

This comment has been minimized.

Copy link
Contributor

@jaytersen jaytersen commented May 1, 2016

It seems like it.

@IngarKCT

This comment has been minimized.

Copy link

@IngarKCT IngarKCT commented Oct 15, 2018

I just saw the line on Vega, interestingly enough, it can be partially occluded by the globe, as if the line runs through it. It's clearly visible when it's on the edge of the globe.
unvanquished_2018-10-15_224808_000

@illwieckz

This comment has been minimized.

Copy link
Member

@illwieckz illwieckz commented Feb 9, 2020

Thinks like SSAO just help to make the lines more obvious, but this is not related to SSAO.

I'm working on some dithering effect to reduce color banding ugliness, and dithering is basically noise, and I see the lines affecting the noise. I already seen the horizontal and vertical line before, but it's also more visible like that. Also, the far-right pixels are wrong too, but that other line is not really problematic in game.

boggy line

I played with curves to make the noise more visible,
and added some ] [ around lines this way: ] | [:

boggy lines

I sometime see another vertical line on the left.

Whith dithering and without ssao, the line may also give the illusion of distorting textures.

This screenshot with stock 0.51.1 build and ssao enabled reveals issue is not really about lines but about screen divided in square tiles, on this screenshot we even have a complete square tile being greyed out (top left), and we clearly see how the horizontal line is distorting the textures with ssao too:

boggy lines

Here we can see the horizontal line, with some issues on the top left square, and we can notice the bottom edge of the top legt square is tilted:

boggy lines

Because, yes, some lines may be either horizontal, either vertical, this screenshot shows an obvious horizontal line (jpeg artifacts help), some tiles on the upper part, and a tilted line:

boggy lines

We also see on those screenshots how the far-right pixels are wrong.

To make the issues more obvious, images can be enlarged by clicking them.

@illwieckz

This comment has been minimized.

Copy link
Member

@illwieckz illwieckz commented Feb 9, 2020

@gimhael, the tile word rings a bell, can it be related to the tiled renderer?

This bug is far beyond my knowledge, help from wizards like gimhael or @cmf028 is needed. 😃

@DolceTriade

This comment has been minimized.

Copy link
Member Author

@DolceTriade DolceTriade commented Feb 9, 2020

This bug predates the tiled renderer.

illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 9, 2020
illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 9, 2020
illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 9, 2020
illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 9, 2020
@illwieckz

This comment has been minimized.

Copy link
Member

@illwieckz illwieckz commented Feb 9, 2020

Maybe I'm a wizard… I may have fixed this bug. 👀

@slipher

This comment has been minimized.

Copy link
Contributor

@slipher slipher commented Feb 10, 2020

Is there some way to reliably reproduce the bug?

illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 10, 2020
illwieckz added a commit to illwieckz/Daemon that referenced this issue Feb 10, 2020
illwieckz added a commit to DaemonEngine/Daemon that referenced this issue Feb 10, 2020
@illwieckz

This comment has been minimized.

Copy link
Member

@illwieckz illwieckz commented Feb 10, 2020

Get this map.

Set this in game (I get the worst results with that resolution) and load the map:

r_FXAA 1
r_ssao 1
r_customwidth 2560
r_customheight 1440
devmap metro

Then fly around the walls, above the lamp, close to the wall, then look at tiled white textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

8 participants
You can’t perform that action at this time.