Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export game surfaceflags to CustomSurfaceFlags.h #1107

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@illwieckz
Copy link
Member

illwieckz commented Mar 4, 2019

This is an easy way to fix DaemonEngine/Daemon#107

I just noticed that those surfaceflags either add new values, either replace existing ones, like game's CONTENTS_NOBUILD sharing the 0x00004000 value with engine's CONTENTS_MOVER.

So in any way, games just want to add values or to override one to do ugly tricks like our game does.

If one day games want a more elaborated behavior, it would be still time to elaborate more.

See also DaemonEngine/Daemon#177 for related PR on the engine side.

@illwieckz illwieckz changed the title export per-game surfaceflags to CustomSurfaceFlags.h export game surfaceflags to CustomSurfaceFlags.h Mar 4, 2019

@illwieckz illwieckz force-pushed the illwieckz:customsurfaceflags branch from 48c0474 to 88a3c84 Mar 4, 2019

@illwieckz illwieckz force-pushed the illwieckz:customsurfaceflags branch from 88a3c84 to 0390811 Mar 5, 2019

/*
===========================================================================
Unvanquished BSD Source Code

This comment has been minimized.

@slipher

slipher Mar 5, 2019

Contributor

Should be GPL?

This comment has been minimized.

@illwieckz

illwieckz Mar 6, 2019

Author Member

That was a question I wanted to ask. Is a such simple thing as a couple of defines in a header is copyrightable from the start? If not, it's better to put a very permissive header so in case of doubt the wording is the most permissive one.

In this case it falls more under the database use case than the code one. Is this code? no there is no logic, it's data. Is there a way to write this data in another way? to be grok by C preprocessor, there is no other way, hence the complete absence of originality. If data can be copyrighted, but can we copyright the 0x4000 number? Hardly. Can we convince any author to release its code under GPL because he used 0x4000 in a define? Not really. It's easier to claim that a list of 6 numbers may be an original work, but those numbers are determined by the flag mechanism itself. We were not able to chose 0x1234, we had to chose a special number from a given list, the same way anyone have to compare first digit to 0 to check for parity.

This comment has been minimized.

@slipher

slipher Mar 6, 2019

Contributor

Aren't we using GPL for the entire gamelogic anyway? In which case the point is moot.

This comment has been minimized.

@illwieckz

illwieckz Mar 10, 2019

Author Member

The gamelogic is using GPL but some files that are meant for interaction with engine are in BSD:

This comment has been minimized.

@illwieckz

illwieckz Mar 10, 2019

Author Member

@DolceTriade or @Viech any word on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.