Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML escape key names #1108

merged 2 commits into from Apr 3, 2019


None yet
2 participants
Copy link

slipher commented Mar 31, 2019

No description provided.

slipher added some commits Mar 25, 2019

Reduce unnecessary copying when calling CG_Init
This also helps me avoid hitting a new codegen bug in Visual Studio
where it can't copy std::array<std::string, 1024> correctly.

@slipher slipher force-pushed the slipher:keyescape branch from 15436b5 to 7bcf5d3 Mar 31, 2019

@@ -485,6 +485,28 @@ static bool IsInvalidEmoticon( Rocket::Core::String emoticon )
return false;

std::string CG_EscapeHTMLText( Str::StringRef text )

This comment has been minimized.

Copy link

DolceTriade Apr 2, 2019


This seems useful to include in other places. noteably Rocket_QuakeToRML and rocketChatField.

This comment has been minimized.

Copy link

slipher Apr 3, 2019

Author Contributor

Yeah, I noticed there were a couple of other places doing escaping. But they also did other transformations and used different string types, so it didn't seem worth trying to combine them somehow.

@slipher slipher merged commit 2f3bddb into Unvanquished:master Apr 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@slipher slipher deleted the slipher:keyescape branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.