Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack for non-0/1 checkboxes #1114

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@slipher
Copy link
Contributor

commented Jul 7, 2019

  • misc deleting

@slipher slipher force-pushed the slipher:checkbox branch from 98801d9 to c6561e9 Jul 7, 2019

@illwieckz

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

I fixed travis so this branch can be rebased on master.

slipher added some commits May 9, 2019

Remove unused graphics presets
These are intended to be invoked by the UI, but aren't used. They look
out of date anyway, with a dubious value for r_dynamicLight and
reference to a nonexistent variable r_inGameVideo.
Don't set "value" attribute for cvar checkboxes
This attribute doesn't do anything for <input type="checkbox"> unless
you are submitting forms.
Add "checked-value" attribute for cvar checkboxes
This hack is intended to be used for r_dynamicLight where the only
advisable values are 0 or 2. The attribute controls what value is
assigned to the cvar when the box is checked.

Also use atoi as a backup when ParseCvarValue<bool> fails, when
converting a cvar value to a checkbox state. It will be more accurate
for legacy cvars.

@slipher slipher force-pushed the slipher:checkbox branch from c6561e9 to 9e0777d Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.