Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return evovle cost even if not possible #1129

Merged
merged 1 commit into from Nov 17, 2019

Conversation

@Gireen
Copy link
Member

Gireen commented Nov 10, 2019

let BG_ClassCanEvolveFromTo return the price even if its not possible to evolve
fixes #1123 together with UnvanquishedAssets/unvanquished_src.dpkdir#8

@slipher

This comment has been minimized.

Copy link
Contributor

slipher commented Nov 11, 2019

I suggest to rename ClassCanEvolveFromTo to something like CostToEvolve, remove the credits argument, and give it the single responsibility of determining the cost to evolve between two classes (or -1 if impossible).

@Gireen Gireen force-pushed the Gireen:evolveprice branch 2 times, most recently from ac67430 to 3325c59 Nov 11, 2019
@Gireen Gireen force-pushed the Gireen:evolveprice branch from 3325c59 to cce906d Nov 11, 2019
@Gireen

This comment has been minimized.

Copy link
Member Author

Gireen commented Nov 11, 2019

ok there is now CostToEvolve for only the costs and ClassCanEvolveFromTo acts as before and uses CostToEvolve

@slipher

This comment has been minimized.

Copy link
Contributor

slipher commented Nov 12, 2019

LGTM

@Gireen Gireen merged commit 010747a into Unvanquished:master Nov 17, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Gireen Gireen deleted the Gireen:evolveprice branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.