Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grangerspit act as trapper #1143

Merged
merged 1 commit into from Jan 4, 2020
Merged

Conversation

@Gireen
Copy link
Member

Gireen commented Dec 26, 2019

Traps humans for a short time. Two seconds seems to be a good start. It gives skilled grangers a way to escape or even kill a single human while leaves humans the possibility to free them self.
Battlesuits are only slowed as before.
config changes in /configs/weapon/abuild.attr.cfg are required for this change to work

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Dec 26, 2019

config changes in /configs/weapon/abuild.attr.cfg are required for this change to work

what is the behavior of the proposed code if that file is not modified accordingly?

Note: the file is hosted there:
https://github.com/UnvanquishedAssets/res-weapons_src.dpkdir/blob/master/configs/weapon/abuild.attr.cfg

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Dec 26, 2019

I like a lot that gameplay change. Since the advgranger spit is not deadly to discourage people to use this form as an attack form (which it is not), the only usage was to extinguish fire. This change gives advancer granger the ability to act decisively in base defense, without attacking itself, and having to rely on teammates, defensive structures or bots to do the job. I think it's very nice.

@Gireen

This comment has been minimized.

Copy link
Member Author

Gireen commented Dec 26, 2019

Just a warning and the spit will trap for 0 seconds

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Dec 26, 2019

Nice, so nothing prevents this to be merged into master, no need to worry about the related file not being updated.

@Gireen Gireen mentioned this pull request Dec 26, 2019
src/sgame/sg_missile.cpp Outdated Show resolved Hide resolved
@slipher

This comment has been minimized.

Copy link
Contributor

slipher commented Dec 26, 2019

Nice, so nothing prevents this to be merged into master, no need to worry about the related file not being updated.

Updating only the code would stop the granger spit slowing from working on non-bsuits, FWIW.

@Gireen Gireen force-pushed the Gireen:grangerspit branch from ebfd9aa to 20b10b5 Dec 31, 2019
@Gireen

This comment has been minimized.

Copy link
Member Author

Gireen commented Dec 31, 2019

Ok now it acts as before if ABUILDER_BLOB_LOCK_TIME is not configured or zero

@illwieckz illwieckz merged commit c50fb44 into Unvanquished:master Jan 4, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.