Fix UI papercuts #1248
Merged
Fix UI papercuts #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! Thank-you for fixing something I even haven't reported yet (was like… low on my priority list)! 👍 |
|
Oh, right, I remember that I wasn't sure about the proper prefix name to give to the new function. Is |
|
I don't know! 😅 |
slipher
reviewed
Dec 29, 2020
|
Looks good generally.
|
necessarily-equal
force-pushed
the
take-into-account-sold-items-when-displaying-if-funds-are-sufficient
branch
from
e654787
to
cf7f84e
Compare
necessarily-equal
force-pushed
the
take-into-account-sold-items-when-displaying-if-funds-are-sufficient
branch
from
cf7f84e
to
fe7d0c5
Compare
|
I've simplified it a bit and rebased on |
Sometimes you have enough money to buy something but first need to sell what conflicting gear you already have. For example when you want to replace your heavy armor to put on on a light armor and have 100 credits in your pocket. The game didn't allow you to buy it and required you to sell it explicitely first. This commit fixes the annoyance. Example test process: * /devmap usstremor * /give momentum 300 * /give funds 400 * *buy power armor* * *try to buy anything else without selling your power armor* note that if you give yourself 1000 credits on the 0.51, you can buy every update, even conflicting, but you can't do that if you have 400 credits.
necessarily-equal
force-pushed
the
take-into-account-sold-items-when-displaying-if-funds-are-sufficient
branch
from
fe7d0c5
to
3b98797
Compare
as said on IRC:
afontain:
do you have some other ui papercuts in mind?
peertubed:
wrong rounding for evos
like if you have 5.99 and you need 6 to evolve
then it displays 6.0, but you can't [buy a dragoon]
should round down
With this commit, it now rounds down as it should.
Example test process:
* `/devmap antares`
* join aliens
* `/give funds 1.99`
* look at what's displayed on bottom-right
necessarily-equal
changed the title
|
I've added another commit and updated the description accordingly |
necessarily-equal
deleted the
take-into-account-sold-items-when-displaying-if-funds-are-sufficient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always allow buying upgrade when funds would be sufficient
Sometimes you have enough money to buy something but first need to sell
what conflicting gear you already have. For example when you want to
replace your heavy armor to put on on a light armor and have 100 credits
in your pocket. The game didn't allow you to buy it and required you to
sell it explicitely first. This commit fixes the annoyance.
Example test process:
note that if you give yourself 1000 credits on the 0.51, you can buy
every update, even conflicting, but you can't do that if you have 400
credits.
Fix rounding annoyance in displayed morph points
as said on IRC:
afontain:
do you have some other ui papercuts in mind?
peertubed:
wrong rounding for evos
like if you have 5.99 and you need 6 to evolve
then it displays 6.0, but you can't [buy a dragoon]
should round down
Example test process:
/devmap antares/give funds 1.99