New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs with corpses #1281
Fix some bugs with corpses #1281
Conversation
e4425d7
to
3f3ddf8
Compare
cd755c0
to
3f3ddf8
Compare
src/shared/bg_utilities.cpp
Outdated
| @@ -165,3 +165,9 @@ void RemoveFlag(int &flags, int flag) { | |||
| void ToggleFlag(int &flags, int flag) { | |||
| flags ^= flag; | |||
| } | |||
|
|
|||
| // sets the first argument the new anim, but toogling the toogle bit | |||
| void BG_NewAnim(int &anim, int newAnim) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not good style to use a reference here - just take one input and return something.
But anyway I don't think this commit is all that helpful in general. It's hard to tell what this function does looking at the name; I'd rather just have the code right there at the callsite, as it is now.
3f3ddf8
to
effc4fd
Compare
|
I've removed the commit for now
…On So, Jan 24, 2021 at 08:21, slipher ***@***.***> wrote:
@slipher commented on this pull request.
In src/shared/bg_utilities.cpp:
> @@ -165,3 +165,9 @@ void RemoveFlag(int &flags, int flag) {
void ToggleFlag(int &flags, int flag) {
flags ^= flag;
}
+
+// sets the first argument the new anim, but toogling the toogle bit
+void BG_NewAnim(int &anim, int newAnim) {
It is not good style to use a reference here - just take one input
and return something.
But anyway I don't think this commit is all that helpful in general.
It's hard to tell what this function does looking at the name; I'd
rather just have the code right there at the callsite, as it is now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
It seems, you removed the wrong commit. |
effc4fd
to
118ce2a
Compare
|
fixed
…On Mo, Jan 25, 2021 at 02:15, slipher ***@***.***> wrote:
It seems, you removed the wrong commit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
No description provided.