Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs with corpses #1281

Merged
merged 2 commits into from Jan 25, 2021

Conversation

necessarily-equal
Copy link
Contributor

No description provided.

@necessarily-equal necessarily-equal changed the title Fix some bug with corpse death anims Fix some bug with corpses Jan 10, 2021
src/shared/bg_public.h Outdated Show resolved Hide resolved
@@ -165,3 +165,9 @@ void RemoveFlag(int &flags, int flag) {
void ToggleFlag(int &flags, int flag) {
flags ^= flag;
}

// sets the first argument the new anim, but toogling the toogle bit
void BG_NewAnim(int &anim, int newAnim) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not good style to use a reference here - just take one input and return something.

But anyway I don't think this commit is all that helpful in general. It's hard to tell what this function does looking at the name; I'd rather just have the code right there at the callsite, as it is now.

@necessarily-equal
Copy link
Contributor Author

necessarily-equal commented Jan 24, 2021 via email

@slipher
Copy link
Contributor

slipher commented Jan 25, 2021

It seems, you removed the wrong commit.

@necessarily-equal
Copy link
Contributor Author

necessarily-equal commented Jan 25, 2021 via email

@slipher slipher merged commit d5d96c2 into Unvanquished:0.52.0/sync Jan 25, 2021
@necessarily-equal necessarily-equal deleted the fix-anims branch January 26, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants