larger and scrollable map list with max-height, fix #667 #669
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DolceTriade
added a commit
that referenced
this pull request
Mar 8, 2015
larger and scrollable map list with max-height, fix #667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is some ui changes to fix #667.
Before this changes, the map list could be longer than the screen, and the map names larger than the map list:
With this fix, the map selector is as large as other form entries (I have enlarged each since it was possible and it allows future needs), scrollable and have a max-height.
The max-height and the scroll bar only appears on long list.
Small list (adaptive height, no scrollbar):
Long list (max height, scrollbar):