Jump to conversation
Unresolved conversations (7)
@cmf028 cmf028 Dec 15, 2016
Bounds check the result of trap_R_BoneIndex. This function can fail with a result of -1.
src/cgame/cg_animdelta.cpp
DolceTriade
@cmf028 cmf028 Dec 14, 2016
See comment below about the abstraction. Barring a correction there (which would change this to store by value), this can also use std::unique_ptr instead of std::shared_ptr.
src/cgame/cg_local.h
DolceTriade
@cmf028 cmf028 Dec 14, 2016
Do we really need this abstraction? Seems like a case of over engineering.
src/cgame/cg_skeleton_modifier.h
DolceTriade
@cmf028 cmf028 Dec 14, 2016
If the above is changed to .insert, this can be changed to just use the count parameter of the std::vector constructor to avoid an allocation.
src/cgame/cg_animdelta.cpp
DolceTriade
@cmf028 cmf028 Dec 14, 2016
prefer .insert with std::move()
src/cgame/cg_animdelta.cpp
DolceTriade
@cmf028 cmf028 Dec 14, 2016
Do we really need to load an animation for WP_NONE?
src/cgame/cg_animdelta.cpp
DolceTriade
@cmf028 cmf028 Dec 14, 2016
This returns "true" in all possible paths. This makes the return value essentially useless
src/cgame/cg_animdelta.cpp
DolceTriade
Resolved conversations (0)