Conversation
gvjacob
commented
Jan 10, 2023
Comment on lines
+5
to
+13
| webpack(config) { | ||
| config.module.rules.push({ | ||
| test: /\.svg$/i, | ||
| issuer: /\.tsx?$/, | ||
| use: ["@svgr/webpack"], | ||
| }); | ||
|
|
||
| return config; | ||
| }, |
Member
Author
There was a problem hiding this comment.
I have a feeling we'll be using a lot of SVGs in this prototype. Instead of loading them async as images on the page, I figured it's more performant to load them inline so that they'll immediately display on the page.
| extend: { | ||
| colors: { | ||
| purple: { | ||
| DEFAULT: "#5D15E3", |
Member
Author
There was a problem hiding this comment.
I pulled this purple from the figma color presets.
catlynbowles
approved these changes
Jan 10, 2023
joshpensky
reviewed
Jan 10, 2023
Contributor
joshpensky
left a comment
joshpensky
left a comment
There was a problem hiding this comment.
Beautiful! 💅 Just left a few comments!
Comment on lines
+1
to
+8
| import React from "react"; | ||
| import GoNoodleLogoLightSVG from "@src/svgs/gonoodle-logo-light.svg"; | ||
|
|
||
| type Props = { | ||
| children?: React.ReactNode; | ||
| }; | ||
|
|
||
| export default function Layout({ children }: Props) { |
Contributor
There was a problem hiding this comment.
A few TS things we'll want to carry forward!
// Let's import these individually for some tree-shaking!
import { PropsWithChildren } from "react";
// A few things here:
// - Let's export all our interfaces (so we can reference them as needed)
// - Let's prefix prop names with the name of their components
// - There's a general preference for interfaces over types for objects! since they're extensible
export interface LayoutProps {}
// Prefer using PropsWithChildren rather than defining children prop
export default function Layout({ children }: PropsWithChildren<LayoutProps>) {
Member
Author
There was a problem hiding this comment.
very very interesting! It all makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
How to Test
yarn installAccessibility Checklist
<img>tags have appropriatealttextSee the
Playbook accessibility page
for more details.