-
Notifications
You must be signed in to change notification settings - Fork 0
Feature: Scene and background assets #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9d4d137
chore: delete api folder
gvjacob 9e03b9d
feat: add base purple color and apply gradient to body
gvjacob a7d115b
feat: adjust purple opacity
gvjacob 9fbdaf8
chore: install svgr for importing svgs as components
gvjacob 1a641cc
feat: include landscape svg at the bottom of the page
gvjacob 040a30d
feat: include clouds svgs around top of page'
gvjacob e472a0f
chore: add husky install as prepare script
gvjacob 1153f28
fix: run prettier
gvjacob 8416c63
fix: create layout component
gvjacob 0555239
feat: add GoNoodle logo to top of page
gvjacob 04662b9
fix: reorder markup and make sure assets don't overflow
gvjacob b648461
fix: add sr text for GN logo
gvjacob 63402e4
fix: adjust header padding
gvjacob 9736ad4
fix: capitalize layout component file name
gvjacob c0f76a2
fix: use typescript conventions for component props
gvjacob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,16 @@ | ||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = { | ||
| reactStrictMode: true, | ||
| } | ||
|
|
||
| module.exports = nextConfig | ||
| webpack(config) { | ||
| config.module.rules.push({ | ||
| test: /\.svg$/i, | ||
| issuer: /\.tsx?$/, | ||
| use: ["@svgr/webpack"], | ||
| }); | ||
|
|
||
| return config; | ||
| }, | ||
| }; | ||
|
|
||
| module.exports = nextConfig; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { PropsWithChildren } from "react"; | ||
| import GoNoodleLogoLightSVG from "@src/svgs/gonoodle-logo-light.svg"; | ||
|
|
||
| export interface LayoutProps {} | ||
|
|
||
| export default function Layout({ children }: PropsWithChildren<LayoutProps>) { | ||
| return ( | ||
| <> | ||
| <header className="absolute top-0 p-4 sm:p-6"> | ||
| <span className="sr-only">GoNoodle</span> | ||
| <GoNoodleLogoLightSVG className="w-32" aria-hidden /> | ||
| </header> | ||
|
|
||
| <main>{children}</main> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| import "@src/styles/globals.css"; | ||
| import type { AppProps } from "next/app"; | ||
| import Layout from "@src/components/Layout"; | ||
|
|
||
| import "@src/styles/globals.css"; | ||
|
|
||
| export default function App({ Component, pageProps }: AppProps) { | ||
| return <Component {...pageProps} />; | ||
| return ( | ||
| <Layout> | ||
| <Component {...pageProps} /> | ||
| </Layout> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| import { Html, Head, Main, NextScript } from 'next/document' | ||
| import { | ||
| Html, Head, Main, NextScript, | ||
| } from "next/document"; | ||
|
|
||
| export default function Document() { | ||
| return ( | ||
| <Html lang="en"> | ||
| <Head /> | ||
| <body> | ||
| <body className="bg-black"> | ||
| <Main /> | ||
| <NextScript /> | ||
| </body> | ||
| </Html> | ||
| ) | ||
| ); | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,32 @@ | ||
| import Head from "next/head"; | ||
| import SuperNoodleWorldLandscapeSVG from "@src/svgs/supernoodle-world-landscape.svg"; | ||
| import SuperNoodleWorldCloudPairSVG from "@src/svgs/supernoodle-world-cloud-pair.svg"; | ||
| import SuperNoodleWorldCloudSingleSVG from "@src/svgs/supernoodle-world-cloud-single.svg"; | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <> | ||
| <div className="relative overflow-x-hidden min-h-screen bg-gradient-to-b from-purple/5 to-purple/30 bg-no-repeat"> | ||
|
gvjacob marked this conversation as resolved.
|
||
| <Head> | ||
| <title>SuperNoodle</title> | ||
| <meta name="description" content="Generated by create next app" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| </Head> | ||
| <main> | ||
| <h1>SuperNoodle</h1> | ||
| </main> | ||
| </> | ||
|
|
||
| <SuperNoodleWorldLandscapeSVG | ||
| className="w-full absolute bottom-0" | ||
| aria-hidden | ||
| /> | ||
|
|
||
| <SuperNoodleWorldCloudPairSVG | ||
| className="w-72 absolute top-10 right-0 translate-x-1/4" | ||
| aria-hidden | ||
| /> | ||
|
|
||
| <SuperNoodleWorldCloudSingleSVG | ||
| className="w-40 absolute top-1/4 -left-12" | ||
| aria-hidden | ||
| /> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| @tailwind base; | ||
| @tailwind components; | ||
| @tailwind utilities; | ||
| @tailwind utilities; |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling we'll be using a lot of SVGs in this prototype. Instead of loading them async as images on the page, I figured it's more performant to load them inline so that they'll immediately display on the page.