Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gvjacob
commented
Jan 18, 2023
Comment on lines
+16
to
+21
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "next/core-web-vitals" | ||
| ], | ||
| "parser": "@typescript-eslint/parser", | ||
| "plugins": ["@typescript-eslint"], |
Member
Author
There was a problem hiding this comment.
Had to reconfigure ESLint to use typescript-eslint so that we use TS rules, and not JS.
Comment on lines
+87
to
+89
| <p className="sr-only" aria-live="polite"> | ||
| {`Move ${neighborsDirections.join(", ")}`} | ||
| </p> |
Member
Author
There was a problem hiding this comment.
This would only say Move up, down, right right now. We can make this more helpful but let's wait until we've included other tile types.
An example of what the accessible text can be in the future.
Currently at a check-in. Press Enter to continue. You may move up, right, or down.
joshpensky
reviewed
Jan 18, 2023
Contributor
joshpensky
left a comment
joshpensky
left a comment
There was a problem hiding this comment.
This is great! 🏆 Just a few comments from reviewing!
# Conflicts: # .eslintrc.json # src/components/WorldBoard.tsx # src/worlds/oms-calming-corner.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
typescript-eslintto properly use eslint for TSCleanShot.2023-01-17.at.19.47.53.mp4
How to Test
yarn installTabkey until the player icon is focused onAccessibility Checklist
<img>tags have appropriatealttextSee the
Playbook accessibility page
for more details.