Skip to content

Fix: prevent moving in direction if invalid#8

Merged
gvjacob merged 2 commits into
mainfrom
GN-85
Jan 18, 2023
Merged

Fix: prevent moving in direction if invalid#8
gvjacob merged 2 commits into
mainfrom
GN-85

Conversation

@gvjacob
Copy link
Copy Markdown
Member

@gvjacob gvjacob commented Jan 18, 2023

What This Does

Check that current player tile can move in the given direction before moving.

How to Test

  1. Move your champ player to a junction like below
  2. Make sure you cannot "jump" (in this case, jump down) to a tile that is adjacent but doesn't have a path between

CleanShot 2023-01-18 at 13 28 23

@linear
Copy link
Copy Markdown

linear Bot commented Jan 18, 2023

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
supernoodle-prototype ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 7:09PM (UTC)

@gvjacob gvjacob changed the title Fix: prevent moving to direction if current tile doesn't have direction Fix: prevent moving in direction if invalid Jan 18, 2023
Copy link
Copy Markdown
Contributor

@joshpensky joshpensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎖️ I'll update #9 once this is merged

@gvjacob gvjacob merged commit 9f6a9cf into main Jan 18, 2023
@gvjacob gvjacob deleted the GN-85 branch January 18, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants