Skip to content

Feature: Add XState#9

Merged
joshpensky merged 4 commits into
mainfrom
gn-50
Jan 18, 2023
Merged

Feature: Add XState#9
joshpensky merged 4 commits into
mainfrom
gn-50

Conversation

@joshpensky
Copy link
Copy Markdown
Contributor

@joshpensky joshpensky commented Jan 18, 2023

What This Does

  • Adds the xstate and @xstate/react libraries
  • Add new machines/move file with the player move machine
  • Implement useMachine with the move machine in WorldBoard
  • Update some prop names in ChampPlayer to match machine events

How to Test

  1. Focus on the champ player
  2. Use the arrow keys to a valid direction. Confirm the player is moved
  3. Use the arrow keys to an invalid direction. Confirm the player is not moved

Accessibility Checklist

  • Markup uses semantic HTML
  • <img> tags have appropriate alt text
  • Links and buttons have discernable text
  • Form inputs have labels
  • Pages are keyboard accessible & focus states are handled

See the Playbook accessibility page for more details.

@joshpensky joshpensky self-assigned this Jan 18, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Jan 18, 2023

GN-50 Sync champ player position

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
supernoodle-prototype ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 9:10PM (UTC)

@joshpensky joshpensky added this to the 0.1.0 milestone Jan 18, 2023
gvjacob
gvjacob approved these changes Jan 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@gvjacob gvjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as advertised! Just a few small fixes to make

Comment thread src/components/WorldBoard.tsx Outdated
Comment thread src/components/WorldBoard.tsx Outdated
Comment thread src/machines/move.ts Outdated
@joshpensky joshpensky merged commit a4d90e3 into main Jan 18, 2023
@joshpensky joshpensky deleted the gn-50 branch January 18, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvjacob gvjacob gvjacob approved these changes

+1 more reviewer

@catlynbowles catlynbowles catlynbowles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@joshpensky @gvjacob @catlynbowles