Skip to content

Conversation

@davidyell
Copy link
Collaborator

Added missing exception class

@davidyell davidyell mentioned this pull request Sep 11, 2015
@ADmad
Copy link
Member

ADmad commented Sep 11, 2015

Can you please add test which triggers this exception.

@davidyell
Copy link
Collaborator Author

I'd love to, but there aren't any tests to go on. I'd feel happier extending existing tests to ensure that the code formatting was similar.

I'll try and write up a test for it, if I can get some time.

@ADmad
Copy link
Member

ADmad commented Sep 11, 2015

Give it a shot and ask for pointers if you get stuck. In general check core for how exception throwing from a method is tested.

@steefaan
Copy link

Maybe you should merge this and do the test cases with a separate PR. Currently you get a Fatal Error because the class is missing. This would solve at least this bad issue.

@davidyell
Copy link
Collaborator Author

It would be handy, as I've just been given a huge project at work, so will not have much time to work on this. I can try and find some time in the evenings, but it's a long shot.

jadb added a commit that referenced this pull request Sep 17, 2015
@jadb jadb merged commit 8401f11 into UseMuffin:master Sep 17, 2015
@jadb
Copy link
Member

jadb commented Sep 17, 2015

I agree @steefaan but giving a hand to @davidyell wouldn't have hurt ;)

@davidyell davidyell deleted the missing-exception branch May 18, 2017 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants