Skip to content

Update dataTypes.md #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

Update dataTypes.md #85

merged 2 commits into from
Oct 6, 2021

Conversation

@shoebxsiddiqui
Copy link
Contributor

@shoebxsiddiqui shoebxsiddiqui commented Oct 4, 2021 •
edited
Loading

Fixes #29

Short description of what this resolves:

What Changes proposed in this pull request:

-Added in-depth documentation on Data Types

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@shoebxsiddiqui
Copy link
Contributor Author

shoebxsiddiqui commented Oct 4, 2021

@Utkarsh1504 Pls have a look at this, If u find this helpfull then kindly merge it.

Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 5, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 requested changes Oct 5, 2021
View reviewed changes
Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit :octocat: the suggested changes, rest all of your content looks great.

@shoebxsiddiqui
Copy link
Contributor Author

shoebxsiddiqui commented Oct 5, 2021

Ok sir @Utkarsh1504 .

@shoebxsiddiqui
Copy link
Contributor Author

shoebxsiddiqui commented Oct 5, 2021

Done , pls review this @Utkarsh1504

Utkarsh1504
Utkarsh1504 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thank you for your hard work 👍🏻

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 5, 2021
@Utkarsh1504 Utkarsh1504 merged commit a22f5c6 into Utkarsh1504:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Utkarsh1504 Utkarsh1504 Utkarsh1504 approved these changes

Assignees

No one assigned

Labels

approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new lesson: Learn Data Types

2 participants

@shoebxsiddiqui @Utkarsh1504