Skip to content

Conversation

@shoebxsiddiqui
Copy link
Contributor

@shoebxsiddiqui shoebxsiddiqui commented Oct 5, 2021

Fixes #77

Short description of what this resolves: Added documentation that was missing in bitwise-operator.md

What Changes proposed in this pull request:

-Add in-depth documentation for the lesson Bitwise Operator.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: I have added a .md file on bitwise operators, that covers in-depth and brief description on the topics including programming questions

@shoebxsiddiqui
Copy link
Contributor Author

@Utkarsh1504 pls review this.

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the suggested changes, Great work! 👍🏻

shoebxsiddiqui and others added 2 commits October 6, 2021 15:12
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui
Copy link
Contributor Author

Pls review this @Utkarsh1504 I think i have resolved the changes required . If not, pls ping me again

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your hard work!🎈✨🎉

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 6, 2021
@Utkarsh1504 Utkarsh1504 merged commit 41f97dc into Utkarsh1504:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new lesson: Compelete Bitwise Operators

2 participants