Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sort order of transparent materials (Godot 4.x engine bug) #10

Open
GeorgeS2019 opened this issue May 8, 2021 · 10 comments
Open

Comments

@GeorgeS2019
Copy link

@GeorgeS2019 GeorgeS2019 commented May 8, 2021

deleted

@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

If a model doss not match the appearance of VRoidHub out of the box, that is a bug.
Could you please link me to the model you are testing with, or DM me the model if it is private? that would help me resolve the issue
Thanks for the report.

regarding name of sub-surfaces, can you tell me what the names are supposed to be on the original model? how do they appear in other tools such as Unity. I will implement it if you can show me where this data comes from.

@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

unfortunately that model no longer allows download.
can you tell me the name of the shader for the broken eyebrow materials?

@GeorgeS2019 GeorgeS2019 changed the title Possible to automatic apply materials correctly to eye brown and slashes of a VRM model? Deleted May 8, 2021
@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

Hi @GeorgeS2019 I was unable to reproduce your issue

image

I really, really appreciate your help testing godot-vrm.

Sorry if it came off harsh. You are literally the first user to test out the new version of godot-vrm and I'm really pleased you got a chance to use it

@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

@GeorgeS2019 fire uploaded a copy of the .zip, and attached the terms of use next to it so as to not risk violating the license. Github helpfully magnified that image to 500% so it looked like yelling. That was just standard practice and nothing you did wrong.

Sorry for the misunderstanding due to a crappy medium of github issue report.

Again I really appreciate your help testing and reporting issues on godot-vrm!

@GeorgeS2019
Copy link
Author

@GeorgeS2019 GeorgeS2019 commented May 8, 2021

@lyuma it is a pleasure to see your passion making godot-vrm works. You are responding positive to feedback. I totally understand and share that others to try and learn the culture reflected by VRM.

@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

So to get back to the OP issue... I think you may have just hit an engine bug in Godot 4.x - since I am not able to reproduce the issue with that model.

(It is dangerous to test in this pre-alpha, unstable engine version. Bugs are rampant)

The bug I think you ran into is one where the faces randomly get flipped inside out. One trigger for this type of issue is opening the same model in two scene tabs. We just need to wait for Godot to fix the issues in Godot 4.x, but Godot is still working on features and so they probably are not going to start bug hunting for a few months.

That said, I'll keep this issue in mind and I'll be on the lookout for it. If you want stability, you'll need to use Godot 3.x - I'm close to finishing my backports to that version.

@GeorgeS2019
Copy link
Author

@GeorgeS2019 GeorgeS2019 commented May 8, 2021

@lyuma backport to Godot 3.x would be an excellent idea. Thanks for keeping up the goal.

@lyuma
Copy link
Contributor

@lyuma lyuma commented May 8, 2021

Ok another theory. This model has multiple transparent materials and it's using Render Priority on some of them. Render Priority is broken on Godot master. So it could be that on your build of Godot, the transparent materials render in a different order than on mine. (it might be undefined)

@GeorgeS2019
Copy link
Author

@GeorgeS2019 GeorgeS2019 commented May 8, 2021

@lyuma I had similar problems with non VRM models. Often I do not have enough experience to know why. Thanks for your suggestion. Something to think about :-)

@lyuma lyuma changed the title Deleted Incorrect sort order of transparent materials (Godot 4.x engine bug) May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants