Refactor VRM import to use bone names; change some properties #1
+281
−47
Conversation
Refactoring lookup of skeleton bones, and move NodePath references to vrm_toplevel. Removes mouth_offset since that was guessed anyway Springbone processing is not implemented yet. We are only creating the objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Save humanoid bone names instead of indices.
Refactoring lookup of skeleton bones, and move NodePath references to vrm_toplevel.
Removes mouth_offset since that was guessed anyway
Store springbone data but do not implement process.
Springbone processing is not implemented yet. We are only creating the objects.
This breaks the vrm_meta format. It is a backwards-incompatible change with existing files.
The text was updated successfully, but these errors were encountered: