Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate quote/escape sequences from main classifier #17

Closed
V0ldek opened this issue Sep 17, 2022 · 0 comments · Fixed by #18
Closed

Separate quote/escape sequences from main classifier #17

V0ldek opened this issue Sep 17, 2022 · 0 comments · Fixed by #18
Assignees
@V0ldek
Labels
area: performance Performance improvements contribute: simd Requires SIMD knowledge type: feature New feature or request
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Sep 17, 2022

Is your feature request related to a problem? Please describe.
Current classifier has two separate jobs. It first detects quoted sequences, taking escapes into account, and then it classifies structural characters on top of that. Separating those concerns would unlock some perfomrance improvement opportunities.

For example, the part that classifies characters could be swapped during execution, for example to conditionally take commas into account, or to do quick skipping passes like JSONSki does.

Describe the solution you'd like
The concerns of "is this within quotes" and "is this an interesting character" should be separated into two modules.
@V0ldek V0ldek added type: feature New feature or request acceptance: go ahead Reviewed, implementation can start contribute: simd Requires SIMD knowledge labels Sep 17, 2022
@V0ldek V0ldek added this to the v1.0.0 milestone Sep 17, 2022
@V0ldek V0ldek self-assigned this Sep 17, 2022
@V0ldek V0ldek mentioned this issue Sep 19, 2022
Merged
V0ldek added a commit that referenced this issue Sep 19, 2022
@V0ldek
feat: separate quote from structural classifiers
7cffdfc 
Closes: #17

* test: add more artificial json tests

* fix: bench panics

* docs: fixed parser category slug for crates.io

* ci: disable fail-fast for easier debugging

* ci: add LFS checkout to GitHub action
@V0ldek V0ldek mentioned this issue Oct 1, 2022
Closed
@V0ldek V0ldek added area: performance Performance improvements mod: classifier and removed acceptance: go ahead Reviewed, implementation can start labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
area: performance Performance improvements contribute: simd Requires SIMD knowledge type: feature New feature or request
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Decouple quote sequences rsonquery/rsonpath
1 participant
@V0ldek