Skip to content

Update security defaults #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2015
Merged

Update security defaults #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified specs/VBA-Web - Specs.xlsm
View file
Open in desktop
Binary file not shown.
22 changes: 14 additions & 8 deletions src/WebClient.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,24 +507,30 @@ Public Function PrepareHttpRequest(Request As WebRequest, Optional Async As Bool
End If

' Setup security
'
' By default:
' - Enable certificate revocation check (especially useful after HeartBleed)
' - Disable redirects (matches cURL behavior)
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableCertificateRevocationCheck) = True
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableRedirects) = False

If Me.Insecure Then
' Disable SSL validation
' - Disable certifcate revocation check
' - Ignore all SSL errors
' Unknown certification authority (CA) or untrusted root, 0x0100
' Wrong usage, 0x0200
' Invalid common name (CN), 0x1000
' Invalid date or certificate expired, 0x2000
' = 0x3300 = 13056
' - Enable redirects
' - Enable https-to-http redirects
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableCertificateRevocationCheck) = False
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_SslErrorIgnoreFlags) = 13056
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableRedirects) = True
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableHttpsToHttpRedirects) = True
Else
' By default:
' - Enable certificate revocation check (especially useful after HeartBleed)
' - Ignore no SLL erros
' - Disable redirects (matches cURL behavior)
' - Disable https-to-http redirects
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableCertificateRevocationCheck) = True
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_SslErrorIgnoreFlags) = 0
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableRedirects) = False
web_Http.Option(web_WinHttpRequestOption.web_WinHttpRequestOption_EnableHttpsToHttpRedirects) = False
End If

' Set headers on http request (after open)
Expand Down