Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI learn #50

Closed
Be-ing opened this issue Sep 13, 2017 · 27 comments
Closed

MIDI learn #50

Be-ing opened this issue Sep 13, 2017 · 27 comments

Comments

@Be-ing
Copy link

@Be-ing Be-ing commented Sep 13, 2017

It would be awesome if modules' knobs could be mapped to MIDI controllers.

@nay-seven
Copy link

@nay-seven nay-seven commented Sep 13, 2017

Andrew Belt say "MIDI learn might land in v1.0 in November/December." :-)

@jackokring
Copy link

@jackokring jackokring commented Sep 13, 2017

@AndrewBelt
Copy link
Member

@AndrewBelt AndrewBelt commented Sep 13, 2017

I'll make a MIDICC2CV module with 16 changable CC outputs in Core later, which is closer to what you're talking about. But this issue's request is about MIDI-to-knob mapping in Rack itself.

@Euphorbium
Copy link

@Euphorbium Euphorbium commented Sep 22, 2017

@AndrewBelt Are you working on this? I might try to implement it, need this asap. Already mapped 2 of knobs by modifying current midi module (my novation launch key mini has no pitch or mod wheels)
Ideas on the looks of the module?

@AndrewBelt
Copy link
Member

@AndrewBelt AndrewBelt commented Sep 22, 2017

It might be ~3 weeks before I can get around to the MIDI Interface revamp, and MIDI learn will likely be even after v1.0 releases. It's still on the TODO list though.

If you need it urgently because of a live show or something, you can hack MidiInterface.cpp near the lines

	case 0xb: // cc
		switch (data1) {
			case 0x01: // mod

by changing the data1 hex number to whatever your controller emits. Then, the Mod output will respond to that controller knob.
EDIT: Sounds like this is what you've already tried.

@Euphorbium
Copy link

@Euphorbium Euphorbium commented Sep 22, 2017

@AndrewBelt AndrewBelt changed the title MIDI mapping MIDI learn Oct 26, 2017
@Dultzo
Copy link

@Dultzo Dultzo commented Dec 9, 2017

Sorry for the other duplicate request post. +1 on OP here. Would LOVE to see Midi Learn added at some point if coding time etc allow.

@wilmermurillo
Copy link

@wilmermurillo wilmermurillo commented Jan 10, 2018

Can't wait to this feature! I would defenitely abandon Reaktor for VCVRack when Midi learning is supported. Thanks for all of your effort!

@JoakimLindbom
Copy link

@JoakimLindbom JoakimLindbom commented Jan 21, 2018

What would be the proper way to implement this? Is there a preferred way to send messages from one module to another (except via Wire::step())?
One way could be to implement a MIDI-wire, working as the normal Wire, but sending 4 values. Another would be to extend ModuleWidget::addParam and implement a ::Step()-method on Knob where received values override the Knob value. I guess the leter is better.

@AndrewBelt
Copy link
Member

@AndrewBelt AndrewBelt commented Jan 21, 2018

The way I'll do it is have a special MIDI-learn core module and a special GUI for hooking up knobs to MIDI channels.

No MIDI wires.

@wilmermurillo
Copy link

@wilmermurillo wilmermurillo commented Jan 31, 2018

@AndrewBelt That's exactly how I had imagined it. Thanks for putting this on board! We love you and VCVRack :D

@Atavic Atavic mentioned this issue Mar 8, 2018
@sixstringeek
Copy link

@sixstringeek sixstringeek commented Mar 9, 2018

Need this to control filters, functions with midi fighter twister if I figure out a template I’ll share it!

@Dopplgngr
Copy link

@Dopplgngr Dopplgngr commented Mar 12, 2018

Would be great to have an "Instant Mapping" mode for MIDI Learn - to address the problem of 1 physical controller meeting a high number of virtual controls and dynamic modules placements. E.g. always map all knobs of active module. Use case would be right hand mouse-navigation to activate modules, left hand could stay on controller moving knobs of that active module.

@amp3rsand
Copy link

@amp3rsand amp3rsand commented Mar 16, 2018

any progress on this feature?

@AndrewBelt
Copy link
Member

@AndrewBelt AndrewBelt commented Mar 16, 2018

@amp3rsand Won't start until Rack 1.0 development is active, which will be 4-6 months from now.

@bgracie
Copy link

@bgracie bgracie commented Mar 29, 2018

Thanks for your great work on Rack @AndrewBelt! When it's time for this feature, might be cool to consider bidirectional mapping -- so ppl with controllers that programmatically show current position (lighted encoders, touchscreen apps) can get proper feedback if they turn mapped knobs from within Rack. This would also open up the possibility of using another program with a more timeline-based UI paradigm to snapshot and sequence parameter changes.

@alectron
Copy link

@alectron alectron commented May 19, 2018

+1 for a Midi-learn feature, that would be brilliant.
Thanks for all the work & love put into this beautiful project!

@alectron
Copy link

@alectron alectron commented Nov 22, 2018

Is this still on track for the 1.0 release ?
I'm still hoping to one day be able to have a dedicated surface mapping... eg use a Novation Launchpad to control the VCV consoles controls among other things.

@KoreTeknology
Copy link

@KoreTeknology KoreTeknology commented Jan 24, 2019

It was in my suggestions list, i would really support this feature.. how can we help this one to come up ?

@amp3rsand
Copy link

@amp3rsand amp3rsand commented Jan 24, 2019

@DoogeJ
Copy link

@DoogeJ DoogeJ commented Mar 23, 2019

+1 for this feature. Its the one big thing I'm missing!

@0mars
Copy link

@0mars 0mars commented May 17, 2019

It's working on rack v1-gpl (branch) for those who can't wait, I absolutely love this feature!

@nay-seven
Copy link

@nay-seven nay-seven commented May 17, 2019

@0mars If you have a Mac release to share, i'm interested ;-)

@0mars
Copy link

@0mars 0mars commented May 17, 2019

@nay-seven unfortunately, I don't have a mac.

@nay-seven
Copy link

@nay-seven nay-seven commented May 17, 2019

ok, no problem, thanks anyway ;-)

@gilbertohasnofb
Copy link

@gilbertohasnofb gilbertohasnofb commented Jun 26, 2019

Has this feature been implemented in the recently released version 1.0?

@AndrewBelt
Copy link
Member

@AndrewBelt AndrewBelt commented Jun 26, 2019

Yes, I believe this can be closed

@AndrewBelt AndrewBelt closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet