Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create source tarball with a script #1406

Closed
wants to merge 1 commit into from

Conversation

dvzrv
Copy link

@dvzrv dvzrv commented Jun 26, 2019

create_assets.sh: Adding script to create assets (including any submodules) as .tar.gz in the form rack-<tag>.tar.gz in the same folder the script is residing in.

Additionally, it can be used to create a detached PGP signature of the created source tarball.

E.g. to create the source tarball for tag v1.0.0:

./create_assets.sh -v v1.0.0

To create the source tarball for tag v1.0.0 and an additional detached PGP signature, where <e-mail> is the mail address you have created a PGP key for:

./create_assets.sh -v v1.0.0 -s <e-mail>

Fixes #1396.

…dules) as .tar.gz in the form rack-<tag>.tar.gz in the same folder the script is residing in.

Additionally, it can be used to create a detached PGP signature of the created source tarball.
@AndrewBelt
Copy link
Member

This looks nice, but since I don't need this (but you do), would you mind keeping it in your fork and pulling/merging whenever you need to update?

@dvzrv
Copy link
Author

dvzrv commented Jun 27, 2019

I'm sorry, but I don't have the time to do that. I maintain over 300 packages.

I don't quite understand your chain of thought: Under what circumstances would you not be interested in having reproducible and verifiable sources for others, guaranteeing a flowing back of information about the build system and the components?
This is not only making my life easier, but basically that of every packager or $person building rack from source.

@AndrewBelt
Copy link
Member

AndrewBelt commented Jun 27, 2019

No worries, I'll merge this if customers start requesting it. Currently it seems they're happy using the official builds, which have the additional advantage of VCV providing professional support for.

@dvzrv
Copy link
Author

dvzrv commented Jun 28, 2019

No worries, I'll merge this if customers start requesting it.

What classifies as a customer though? How many more than two users on github requesting it would be required?

Currently it seems they're happy using the official builds, which have the additional advantage of VCV providing professional support for.

That might be. However, there literally are no other builds available (or packages for that matter) that they could even choose from (software on Linux is usually installed via package managers).

@falkTX
Copy link

falkTX commented Jun 28, 2019

I think kxstudio users would be quite happy to have this packaged properly in the repos.
Should I tell them to voice their opinion here?

@dvzrv
Copy link
Author

dvzrv commented Jun 28, 2019

The same goes for Arch Linux/ Manjaro/ Parabola, etc. users.

@trebmuh
Copy link

trebmuh commented Jun 28, 2019

LibraZiK users would welcome having Rack nicely and properly packaged in the users repository too.

@diovudau
Copy link

Your userbase might be windows, by the sheer numbers alone, but your power-user and open source-base is linux. Making sure building and packaging can be done properly is a high priority for every project.

@eeickmeyer
Copy link

eeickmeyer commented Jun 28, 2019

Leader of Ubuntu Studio here. Arguably, Ubuntu Studio is the largest, most widely used multimedia creation operating system on the planet. I was actually looking at packaging this and getting it included in the Ubuntu repositories and then included in Ubuntu Studio by default, but I can't do that unless there's a proper source tarball.

So, that's a +1 from me. Doing this would get your software in front of users and recording studios worldwide that don't run (and don't want to run) Windows.

@VCVRack VCVRack deleted a comment from erwan35 Jun 28, 2019
@VCVRack VCVRack deleted a comment from Animtim Jun 28, 2019
@VCVRack VCVRack deleted a comment from rghvdberg Jun 28, 2019
@VCVRack VCVRack deleted a comment from jpcima Jun 28, 2019
@AndrewBelt
Copy link
Member

Moving to #1396 as an implementation of this should be in Makefiles, not a script.

@AndrewBelt AndrewBelt closed this Jun 28, 2019
@VCVRack VCVRack deleted a comment from stilvoid Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants