change notification for truncated axis #397
Conversation
| ); | ||
| } | ||
| }, [truncationConfigIndependentAxisMin, truncationConfigIndependentAxisMax]); | ||
|
|
||
| useEffect(() => { | ||
| if (truncationConfigDependentAxisMin || truncationConfigDependentAxisMax) { | ||
| setTruncatedDependentAxisWarning( | ||
| 'Data may have been truncated (light gray area) by range selection' | ||
| ' Data may have been truncated (light gray area) by range selection' |
There was a problem hiding this comment.
It would be nice not to need the leading space. Can the Notification component take care of this?
There was a problem hiding this comment.
@bobular thank you for your review and comments 👍 I will try to make this at Notification component level.
| @@ -548,15 +548,15 @@ function HistogramPlotWithControls({ | |||
| truncationConfigIndependentAxisMax | |||
| ) { | |||
| setTruncatedIndependentAxisWarning( | |||
| 'Data has been truncated (light gray area) by range selection' | |||
| ' Data has been truncated (light gray area) by range selection' | |||
There was a problem hiding this comment.
I don't really like how these warnings read. I'd prefer something like
Data has been truncated by range selection, as indicated in the plot by the light gray shading.
What do @danicahelb and @SheenaTomko think?
I know that's very long, but there is space for two lines of text in the blue notification area. I tried a longer message and it will need some CSS changes so that it wraps more aggressively and doesn't make the blue box much wider.
There was a problem hiding this comment.
@bobular will try. It would be a bit tricky to change CSS though
There was a problem hiding this comment.
@bobular As suggested I have made single space at Notification component so the single space at histogram filter is removed
There was a problem hiding this comment.
@bobular also adjusted notification size with the new message by setting style from histogram filter component. Like,
|
I might change it slightly to "Data has been truncated by range selection, as indicated by the light gray shading." |
This issue replies on the corresponding PR at web-components. Details can be found at the PR.