Skip to content

fix handling of shutdown request and exit notification #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2025
Merged

fix handling of shutdown request and exit notification #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions vhdl_ls/src/stdio_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ impl ConnectionRpcChannel {
match message {
lsp_server::Message::Request(request) => {
match self.connection.handle_shutdown(&request) {
Ok(shutdown) => {
if shutdown {
Ok(should_exit) => {
if should_exit {
server.shutdown_server();
server.exit_notification();
} else {
self.handle_request(&mut server, request)
}
Expand Down Expand Up @@ -272,11 +273,6 @@ impl ConnectionRpcChannel {
Ok(params) => return server.workspace_did_change_watched_files(&params),
Err(notification) => notification,
};
// exit
let notification = match extract::<notification::Exit>(notification) {
Ok(_params) => return server.exit_notification(),
Err(notification) => notification,
};

if !notification.method.starts_with("$/") {
debug!("Unhandled notification: {notification:?}");
Expand Down
Loading