Skip to content

fix target_f_name computing #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shamzik merged 2 commits into from
Mar 4, 2026
Merged

fix target_f_name computing #1543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47f0c7
just to_string
Shamzik Mar 4, 2026
8b9205c
strong check `is_string`
Shamzik Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions compiler/code-gen/files/tl2cpp/tl-combinator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,14 @@ void CombinatorStore::gen_arg_processing(CodeGenerator &W, const std::unique_ptr
W << "auto _cur_arg = "
<< fmt_format("tl_arr_get(tl_object, {}, {}, {}L)", tl2cpp::register_tl_const_str(arg->name), arg->idx, tl2cpp::hash_tl_const_str(arg->name))
<< ";" << NL;
W << "string target_f_name = "
<< fmt_format("tl_arr_get(_cur_arg, {}, 0, {}L).as_string()", tl2cpp::register_tl_const_str("_"), tl2cpp::hash_tl_const_str("_"))
W << "mixed target_f_name_mixed = "
<< fmt_format("tl_arr_get(_cur_arg, {}, 0, {}L)", tl2cpp::register_tl_const_str("_"), tl2cpp::hash_tl_const_str("_"))
<< ";" << NL;
W << "if (!target_f_name_mixed.is_string()) " << BEGIN
<< R"(CurrentTlQuery::get().raise_storing_error("Field \"_\" of \")" << arg->name << R"(\" array is not string");)" << NL
<< "return {};" << NL
<< END << NL;
W << "string target_f_name = target_f_name_mixed.as_string();" << NL;
W << fmt_format("if (!{}tl_storers_ht.has_key(target_f_name)) ", k2_tl_storers_prefix) << BEGIN
<< "CurrentTlQuery::get().raise_storing_error(\"Function %s not found in tl-scheme\", target_f_name.c_str());" << NL
<< "return {};" << NL
Expand Down
Loading