Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: fixed collectors of colors #4

Merged
merged 5 commits into from Jun 27, 2021
Merged

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jun 27, 2021

Type: bugfix

  • Added full tracking of class colors, now all classes will be cached;

  • RootIndexer now sets colors for classes and functions and also handles
    cases when a class and method have colors that should be mixed;

  • RootChecker no longer sets colors for classes and functions, but only checks
    them, which can now issue several warnings at once, rather than one.

Fixes #3

i582 added 5 commits June 28, 2021 01:59
- Added full tracking of class colors, now all classes will be cached;

- RootIndexer now sets colors for classes and functions, and also handles
  cases when a class and method have colors that should be mixed;

- RootChecker no longer sets colors for classes and functions, but only checks
  them, which can now issue several warnings at once, rather than one;

- The behavior was fixed when the class did not have a constructor, but the 'new'
  operator was called, which led to the fact that the link was not created and
  the error was not caught.
…ith error messages rather than array of 'error' type
…does not exist, because of this, concurrent writing and reading in the map appears
@i582 i582 added the bug Something isn't working label Jun 27, 2021
@i582 i582 merged commit e8ecf1f into master Jun 27, 2021
@i582 i582 deleted the pmakhnev/fixed_class_colors branch June 28, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@color of method isn't merged to @color of the class
1 participant