fix: ignore dtx streams #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgmel
reviewed
Feb 7, 2025
src/helpers/streams.ts
Outdated
| stdDevThreshold = 30, | ||
| ): boolean => { | ||
| const frameIntervals: number[] = []; | ||
| for (let i = 0; i < allProcessedStats.length - 1; i += 1) { |
Collaborator
There was a problem hiding this comment.
i should probably start from 1 (because previousVideoStreamStats are supposed to be a previous element of allProcessedStats array)
src/helpers/streams.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| const mean = frameIntervals.reduce((a, b) => a + b, 0) / frameIntervals.length; |
Collaborator
There was a problem hiding this comment.
Let's use calculateMean() function from helpers here
src/helpers/streams.ts
Outdated
| } | ||
|
|
||
| const mean = frameIntervals.reduce((a, b) => a + b, 0) / frameIntervals.length; | ||
| const variance = frameIntervals |
Collaborator
There was a problem hiding this comment.
What about moving this code to a helper function for variance calculation? and may be event second one for standard deviation calculation?
evgmel
approved these changes
Feb 7, 2025
Collaborator
evgmel
left a comment
evgmel
left a comment
There was a problem hiding this comment.
Thanks for the refactoring 👍
Contributor
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore streams encoded with DTX option due to high FPS volatility and false positive freezeCount results in WebRTC Stats.