Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Only use regex lookbehind where supported #3525
What this PR does / why we need it:
Users on older versions of VSCode were hitting bugs because of lookbehinds in the camel case motion regex. This should fix the issue for those users.
Which issue(s) this PR fixes
Special notes for your reviewer:
Hey! We're using VSCodeVIM inside CodeSandbox (https://codesandbox.io/s/new), which runs VSCode + extensions. For our VIM Mode we use VSCodeVIM (thanks for building this!).
This worked great so far, but we found out that lookbehind regexpressions are not supported in Firefox. I can imagine that this is a very unusual request but would you be open to a PR that adds the lookbehind check and disables it if it detects Firefox/Safari?