Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use regex lookbehind where supported #3525

Merged
merged 4 commits into from Apr 8, 2019

Conversation

@JKillian
Copy link
Contributor

commented Feb 26, 2019

What this PR does / why we need it:

Users on older versions of VSCode were hitting bugs because of lookbehinds in the camel case motion regex. This should fix the issue for those users.

Which issue(s) this PR fixes

Fixes #3522

Special notes for your reviewer:
I didn't get to test this myself on an older version of VSCode. But I think it should work?

@jshap70

This comment has been minimized.

Copy link

commented Feb 26, 2019

This is very similar to what I was testing. Looks fine. Special note that if a user is building vscodevim on an older branch that some test cases will fail, but seems fine to just say that is disallowed.

@JKillian

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Closing this since nobody has complained that they can't upgrade VSCode yet. Will keep the branch around for now though in case it becomes necessary

@CompuIves

This comment has been minimized.

Copy link

commented Apr 3, 2019

Hey! We're using VSCodeVIM inside CodeSandbox (https://codesandbox.io/s/new), which runs VSCode + extensions. For our VIM Mode we use VSCodeVIM (thanks for building this!).

This worked great so far, but we found out that lookbehind regexpressions are not supported in Firefox. I can imagine that this is a very unusual request but would you be open to a PR that adds the lookbehind check and disables it if it detects Firefox/Safari?

@JKillian

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

reopening for consideration since it seems like there are some legit use cases

@JKillian JKillian reopened this Apr 3, 2019

JKillian and others added 2 commits Apr 3, 2019

@jpoon jpoon merged commit 5a949b6 into VSCodeVim:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.