-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need MSI Enterprise Installer #106
Comments
Hi @hypercube33 -- can you provide more info? Is this an installer that is currently provided by Microsoft for Visual Studio Code but that VSCodium does not offer? |
MSIs are not provided by Microsoft for VSCode from what I can tell. Likely this is being asked for to facilitate better/automated installations. MSIs commonly have silent installations which make doing remote installs much simpler and less disruptive/intrusive for end users. |
Some light research turns up a number of free tools to convert exe's to msi's... |
Converting exe to msi is generally frowned upon vs. making a wix script and building a properly functioning msi installer. As for the reason suggesting it yes it's for Enterprise deployment and it's the default package type for windows |
PRs welcome! I don't know much of anything about creating a properly function MSI installer and since MS is not providing this already for Visual Studio Code it isn't at the top of the priority list. That being said, I'd be happy to merge in any contribution towards this end 👍 |
Just became aware of vscodium. I‘m willingly to update my wix based vscode msi setup to latest version asap if it has a chance to get integrated. Just one question. Can we have a registry key or place a file somewhere that disables automatic updates per machine, please? This is an enterprise need... I really need. Ms project manager refused to use msi as he has no idea about enterprise needs and customer needs. |
Hi @alexhass 👋 Thanks for chiming in, as I believe you have the most context/experience with this issue. We would love your help in getting an MSI setup and would gladly include the MSI on the releases page. Unfortunately, disabling automatic updates with a file or registry key would have to happen at the VSCode level. This repo is just running their existing build scripts and uploading the resulting binaries. As such, we can modify small things pre-build like the values in |
Do you know if there is a way to add a killswitch for automatic updates to product.json? |
product.json values are static once the app is built. So it would not be a switch, it would be either on or off for that binary. |
Couldn't the settings JSON file be deployed with a GPO? All enterprise standard settings could be put in the JSON including disabling automatic updates. There is a possibility that the user changes the JSON but this should not be a roadblock for an MSI installer! Any updates on this issue? Or, @alexhass have you thought about releasing the MSIs for VSCode similarly to the other software MSIs you have? It seems clear that the VSCode team has no enterprise experience (and in general no awareness of MS technologies) and an official MSI installer seems likely to never happen. |
I could, but if automatic updates are not disabled the local installation will be destroyed by an update from msi to exe. If we can disable this auto update in the product file I‘m fine! |
I am not familiar with how VSCode works so @stripedpajamas' answer doesn't tell me anything but it would seem like And if all else fails, could automatic updates be disabled in the default Judging by the size of the MSI threads at VSCode side plenty of folks would be happy if VSCodium would have an MSI installer. |
If we know for sure I build the installer. It is more or less ready. I only need to check what has changed in last year and replace a few logos plus testing... |
I've had another look at this issue since at VSCode side there seems to be unfortunately some movement in creating an MSIX installer and not an MSI installer. GPO could not be easily used to deploy a |
hello, any update? please look for office, sql server and other Microsoft products. all them have deployment solution per computer. in enterprise environment is normal distribute via MSI packages with off automatic updates due to stability and compatibility of environment (other plugins, and solutions). you can read about this theme in my article https://translate.google.cz/translate?sl=cs&tl=en&u=https%3A%2F%2Fwww.michalzobec.cz%2Fapplication-deployment-obvykle-postupy-a-zvyky-pro-nasazovani-aplikaci-ve-firemnim-prostredi-5395 please inspire on Keepass or GreenShot |
@alexhass I've had a look at this: yes, you should be able to auto-disable the default setting for the update mode. It is defined in https://github.com/microsoft/vscode/blob/master/src/vs/platform/update/common/update.config.contribution.ts (as "default"). I'd be keen to see your PR here and to recheck with you about how to improve it (one thing I've spot in the initial PR: the build number should be read from tje checkout of https://github.com/microsoft/vscode/blob/master/package.json for example, but a dirty ´findstr I'm looking forward for this :-) Note: if you completely go down this route you'd very likely setup an own local vsix registry and distribute the environment variables via AD that tell VSCodium to use this local repository instead of the one VSCodium is configured with. |
Created the pull. I share ready to use MSI setups (x64/x86) tomorrrow for testing. |
PREVIEW builds are available at https://www.hass.de/content/vscodium-msi-package-enterprise-deployment-available |
Removing inno_update.exe has not helped. What is this executable doing? Setting product,json > updateUrl = "" (empty) seems to remove the update feature from the application. The update check link disapeared everywhere. Great. What made me wondering is that VSCodium has not complained that I altered the product.json file. I think this was the case with vscode in past. I think this needs some investgation. |
That's an interesting question then.
Why should it complain? |
I can only guess... and my best guess is that a malicious software can silently alter the vscode source code. By checking file consistency they can prevent vscode to run with thos code... i‘ve seen this a year ago or so... |
is there an MSI file available yet? |
There's no official build for it but with #574 you'd be able to manually create it. Hm, I think I should try to find some time to handle the open TODO list for that PR- the main part was already provided... |
@GitMensch I'm working on it 😉 |
The MSI are available! |
Cool, both the ones with and the ones without updates disabled are available now. |
At least in |
Great news. Thanks |
No description provided.
The text was updated successfully, but these errors were encountered: