Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat attribute #26

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@rlove
Copy link
Contributor

commented Dec 19, 2013

This is the code that implements RepeatAttribute.

Changes to DUnitX.Tests.TestFixture to test this behavior,
Note: It does have 2 tests that should fail. Since this would most likely break CI setups I have wrapped the registration for these test in
{$IFNDEF CI} {$ENDIF}

rlove added some commits Dec 19, 2013

Implement the RepeatTest Attribute.
Changes to DUnitX.Tests.TestFixture to test this behavior,
Note: It does have 2 tests that should fail.   Since this would most likely break CI setups I have wrapped the registration for these test in
 {$IFNDEF CI} {$ENDIF}
@rlove

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2013

The will not merge well with my other pull request for Data Driven Attributes.
As they both make major changes to the same method.

I would prefer if the Data Driven Attributes, was merged first.

Don't feel like this approach to RepeatAttribute is great. It just seems lacking and I can't figure out why.

Feedback is welcome, and I can re-implement based on the main branch.

@vincentparrett

This comment has been minimized.

Copy link
Member

commented Dec 28, 2013

Hi Robert

I didn't attempt to merge this, after merging your other pull request this is not auto merging. Can you merge master into your fork again and fix up? I don't have any suggestions for a better way to do it, thats the reason I left it unimpmented originally.

@rlove

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2014

Closing as I will submit this again, or we will use Sean B. Durkins implementation.

Having not determined which approach is better.

@rlove rlove closed this Jan 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.