New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In 0.7.3, Tokenizer causes Save Changes button in Settings to be impossible to save #22
Comments
Can confirm. I'll add the error I saw. Seems like the loading of the default frames in the settings got borked.
|
So I've been digging into this for the last hour or so and I think I know what the issue is. The settings fields for both "default npc frame" and "default pc frame" have a setting data type of "Image" as indicated by the console error foundry doesn't like that. I looked into how foundry parses the settings and it looks like it has a series of different cases that it is setup to handle based on the settings data type. I see how it would handle and "Img" but there is not definition of how to handle an "Image". As far as a fix for it, it looks I can try to look into it a little more and see if I can figure out a fix but any further insight would be super helpful. |
This is still ocurring with both tokenizer and iconizer... |
Based on the comment from @BradKriss I tested changing the ImagePicker.Image to ImagePicker.Img and it fixed the issue for me. Created a pull request for it: #26 The iconizer shouldn't be impacted as it doesn't define images in its settings. |
I just tested this on 0.7.5 and it works! |
Any chance we can get this merged? The fix seems simple enough, and I'd prefer not to do a custom mod install if I don't have to. |
For what it's worth I took what ceraetes did and made edits to the module.json to make it directly installable from Github. You can use this link: https://raw.githubusercontent.com/vprenner/vtta-tokenizer/master/module.json |
@MrPrimate one of the contributor on the vtta discord also created a package already: https://github.com/MrPrimate/vtta-tokenizer/releases/download/latest/module.json |
Version 0.7.6 introduces further issues with Tokenizer. @vprenner have you had a chance to try tokenizer in this version? |
Confirmed with Find the Culprit. The Settings menu is impossible to close and impossible to save the settings.
The text was updated successfully, but these errors were encountered: