Bugfix/axis slave back to back transfers #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2022 09:41
The pop'ed message must be deleted after being parsed.
During the delta-cycle for handling of 'notify_bus_process_done', new message_queue items may be issued, esp. when running the "other side" in a "single sample while loop". Checking the queue before sleeping allows back-to-back reads/writes of the axi-stream.
LarsAsplund
approved these changes
Aug 31, 2022
LarsAsplund
reviewed
Aug 31, 2022
| else | ||
| if is_empty(message_queue) then | ||
| -- Wait for messages to arrive on the queue, posted by the process above | ||
| wait until (not is_empty(message_queue) or areset_n = '0') and rising_edge(aclk); |
There was a problem hiding this comment.
All this looks more correct than it was before but I see that the asynchronous reset is basically checked at the rising edge of the clock such that its assertion becomes synchronous rather than asynchronous. Deassertion is correctly synchronous. I think that can be fixed in a separate PR.
LarsAsplund
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shall fix the back-to-back transfer issue for axi-stream master/slave. This may fix #573.