Skip to content

Add stricter requirements to the database summary test and add logging #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add stricter requirements to the database summary test and add logging #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/mock_vws/test_database_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import base64
import io
import logging
from time import sleep

import pytest
Expand All @@ -22,6 +23,9 @@
)
from tests.mock_vws.utils.assertions import assert_vws_response

LOGGER = logging.getLogger(__name__)
LOGGER.setLevel(logging.DEBUG)


@timeout_decorator.timeout(seconds=500)
def _wait_for_image_numbers(
Expand Down Expand Up @@ -63,15 +67,21 @@ def _wait_for_image_numbers(
while True:
response = database_summary(vuforia_database=vuforia_database)

requirements = {
not_matching_requirements = {
requirement: value
for requirement, value in requirements.items()
if response.json()[requirement] != value
}

if not requirements: # pragma: no cover
if not not_matching_requirements: # pragma: no cover
return

LOGGER.debug('Waiting for database summary.')
LOGGER.debug('Waiting for summary to equal: ')
LOGGER.debug(requirements)
LOGGER.debug('Not matching are:')
LOGGER.debug(not_matching_requirements)

# We wait 0.2 seconds rather than less than that to decrease the number
# of calls made to the API, to decrease the likelihood of hitting the
# request quota.
Expand Down