Simplify syslog module usage #15

Merged
merged 2 commits into from Feb 13, 2014

Conversation

Projects
None yet
2 participants
Contributor

okeuday commented Feb 6, 2014

  • It seems like lager_syslog must require that either:
    1. syslog:start/0 or syslog:start_link/0 was called
    2. syslog_drv.so is in the PATH environment variable for
      erlang:open_port/2 to find as a port driver
      Both of these options have nothing to do currently with starting
      syslog as an application. This all seems odd, so I just added a
      load/0 function and an unload/0 function to make it easier to use the
      port driver without relying on an extra Erlang process that sits idle
      or the PATH environment variable's extra entry.

okeuday added some commits Feb 6, 2014

@okeuday okeuday Simplify syslog module usage
* It seems like lager_syslog must require that either:
  1) syslog:start/0 or syslog:start_link/0 was called
  2) syslog_drv.so is in the PATH environment variable for
     erlang:open_port/2 to find as a port driver
  Both of these options have nothing to do currently with starting
  syslog as an application.  This all seems odd, so I just added a
  load/0 function and an unload/0 function to make it easier to use the
  port driver without relying on an extra Erlang process that sits idle
  or the PATH environment variable's extra entry.
bce0856
@okeuday okeuday Expose logopt/1 as openlog_opts/1 for validation of syslog input. 92d4a86
Contributor

okeuday commented Feb 11, 2014

I added another function to expose for external validation. It helped make it a bit simpler. Many of the pull requests seem to be invalid based on the current code. Any feedback?

Vagabond merged commit 91c892f into Vagabond:master Feb 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment