Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use https://github.com/jcomellas/bstr instead of the implementation in the repo #54

Closed
AeroNotix opened this Issue Dec 7, 2013 · 6 comments

Comments

Projects
None yet
4 participants
Contributor

AeroNotix commented Dec 7, 2013

Reduce complexity and reduce reimplemented code in the Erlang world.

What say ye?

Contributor

seriyps commented Dec 9, 2013

The only note: jcomellas/bstr doesn't use binary module at all. I don't know if it matters. But I like the idea.

Contributor

AeroNotix commented Dec 9, 2013

So, I work with @jcomellas so I can see how he feels with me adding shims/whatever/reimplementing using just the binary module.

@AeroNotix I'm fine with making any necessary changes or additions. BTW, some of the functions are the way they are because of historical reasons or to support older versions of Erlang. FYI, this library was created before OTP provided the binary module.

Owner

Vagabond commented Dec 9, 2013

Right, I wonder if gen_smtp should just use the binary module directly as arguably the reason for the shim's existance has passed.

Well, the functionality provided by the binary module does not cover what bstr does. Maybe an option would be to push the missing functions to the binary module and see if the OTP team accepts this contribution. I doubt I'll have time for this in the near future, though.

Contributor

AeroNotix commented Dec 10, 2013

It's something I can work on. I'll write up a draft to one of the Erlang mailing lists and see if they would accept that.

@AeroNotix AeroNotix closed this Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment