Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

RFC allows up to 254 character from addresses #27

Merged
merged 2 commits into from Aug 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

cbd commented Aug 20, 2012

We noticed that mixpanel can't send messages to our gen_smtp server, and traced it down to length. This patch upgrades the parse limit from 129 chars to 254.

Owner

Vagabond commented Aug 20, 2012

Got a link to the relevant RFC piece?

Contributor

cbd commented Aug 20, 2012

http://tools.ietf.org/html/rfc3696

though sorry, i was mistaken - it's 320... and technically, the local part can only be 64 but i think that enforcing that literally would cause problems. Here's the "valid in the real world" address that tripped up the server (i just changed the sensitive part w/foobar and left the replacement the same length):

bounce+44267.994.14182.bf0a61cea14fee208b06ae938d26e2cb-bf0a61cea14fee208b06ae938d26e2cb=foobar.bazfoo1.sh@mail02.datadrivenemail.com

Owner

Vagabond commented Aug 21, 2012

So should we just allow 320 overall length and call it good?

Contributor

cbd commented Aug 21, 2012

yeah that makes sense

On Tue, Aug 21, 2012 at 12:23 PM, Andrew Thompson
notifications@github.comwrote:

So should we just allow 320 overall length and call it good?


Reply to this email directly or view it on GitHubhttps://github.com/Vagabond/gen_smtp/pull/27#issuecomment-7904661.

Owner

Vagabond commented Aug 21, 2012

Wanna amend your commit so I can be lazy and just hit the merge button? ;)

Contributor

cbd commented Aug 21, 2012

done

Vagabond added a commit that referenced this pull request Aug 21, 2012

Merge pull request #27 from inaka/master
RFC allows up to 254 character from addresses

@Vagabond Vagabond merged commit f5eed6a into Vagabond:master Aug 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment