Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't tell error_logger that gen_smtp_server is listening when it is not. #35

Merged
merged 2 commits into from Mar 15, 2013

Conversation

Projects
None yet
2 participants
Contributor

mmzeeman commented Mar 14, 2013

When gen_smtp_server starts and the port it wants to listen is in use it erroneously reports that it is listening.

This fix makes sure that the messages sent to error_logger are true and it also reports problems.

@arjan arjan added a commit that referenced this pull request Mar 15, 2013

@arjan arjan Merge pull request #35 from mmzeeman/init_error_logger
Don't tell error_logger that gen_smtp_server is listening when it is not.
40dea60

@arjan arjan merged commit 40dea60 into Vagabond:master Mar 15, 2013

Collaborator

arjan commented Mar 15, 2013

nice, looks good.
Just out of interest, why did you move the trap_exit call?

Contributor

mmzeeman commented Mar 15, 2013

You only have to call it once, so I moved it outside the list comprehension.

On 15 mrt. 2013, at 08:10, Arjan Scherpenisse notifications@github.com wrote:

nice, looks good.
Just out of interest, why did you move the trap_exit call?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment