Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #1

Open
wants to merge 1 commit into
base: master
from

Conversation

@gautham678
Copy link

gautham678 commented Sep 28, 2019

No description provided.

Copy link

gaharavara left a comment

My major suggestion would be to Add a proper commit message and description to make others understand what changes you have done and why, that would make new contributors understand the
intent of the commit : )

P.S. : I picked this PR via Pull Request Roulette.

Copy link

britho left a comment

Your code does not "Add file via upload" as suggested by the title of the PR.

I suggest that you don't open a PR until it is in a working state with, at the very least, passing unit tests. BDD is the widely used paradigm in favor of TDD now. Become familiar with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.