Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Copy index from anaconda #12

Merged

Conversation

@ericdill
Copy link
Contributor

ericdill commented Dec 6, 2016

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2016

Current coverage is 91.12% (diff: 92.79%)

Merging #12 into master will increase coverage by 3.38%

@@             master        #12   diff @@
==========================================
  Files             2          2          
  Lines           155        169    +14   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            136        154    +18   
+ Misses           19         15     -4   
  Partials          0          0          

Powered by Codecov. Last update 591fd3f...2718c3b

@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Dec 6, 2016

@mariusvniekerk code review please

@ericdill ericdill changed the title WIP: Copy index from anaconda ENH: Copy index from anaconda Dec 6, 2016
@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Dec 6, 2016

@Rapportus code review please

@@ -0,0 +1,7 @@
blacklist:

This comment has been minimized.

Copy link
@parente

parente Dec 7, 2016

Collaborator

Comments about how these fields work would help would-be users.

This comment has been minimized.

Copy link
@parente

parente Dec 7, 2016

Collaborator

Also, the wildcard syntax.

This comment has been minimized.

Copy link
@ericdill

ericdill Dec 7, 2016

Author Contributor

Have a look at the updates to README

This comment has been minimized.

Copy link
@ericdill

ericdill Dec 7, 2016

Author Contributor

Do those changes satisfy that request?

args = ['-v']
# show the message output for skipped and expected failure tests
args.append('-rxs')
print('sys.argv={}'.format(sys.argv))

This comment has been minimized.

Copy link
@parente

parente Dec 7, 2016

Collaborator

Left over print?

This comment has been minimized.

Copy link
@ericdill

ericdill Dec 7, 2016

Author Contributor

Perhaps. I still find it useful to see such things, so I'd prefer to just leave it


def test_match(repodata):
repodata_info, repodata_packages = repodata.anaconda
matched = conda_mirror.match(repodata_packages, {'name': 'jupyter'})

This comment has been minimized.

Copy link
@parente

parente Dec 7, 2016

Collaborator

A wildcard test case somewhere would be good too.

This comment has been minimized.

Copy link
@ericdill

ericdill Dec 7, 2016

Author Contributor

done

@parente

This comment has been minimized.

Copy link
Collaborator

parente commented Dec 7, 2016

Nothing else major to contribute on this.

Copy link

Rapportus left a comment

This looks good!

@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Dec 7, 2016

@ericdill ericdill merged commit a6e20fd into Valassis-Digital-Media:master Dec 7, 2016
3 checks passed
3 checks passed
codecov/patch 92.79% of diff hit (target 87.74%)
Details
codecov/project 91.12% (+3.38%) compared to 591fd3f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill deleted the ericdill:copy-index-from-anaconda branch Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.