Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rework conda mirror to not use conda-index #14

Merged
merged 10 commits into from Dec 12, 2016

Conversation

@ericdill
Copy link
Contributor

ericdill commented Dec 8, 2016

No description provided.

@ericdill ericdill requested review from mariusvniekerk and parente Dec 8, 2016
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 8, 2016

Current coverage is 92.77% (diff: 89.65%)

Merging #14 into master will increase coverage by 1.65%

@@             master        #14   diff @@
==========================================
  Files             2          2          
  Lines           169        180    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            154        167    +13   
+ Misses           15         13     -2   
  Partials          0          0          

Powered by Codecov. Last update 7d00550...0f88254

@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Dec 8, 2016

what's left: figure out how to make validation work

try:
info = repodata[package]
except KeyError:
logging.info("%s is not in the upstream index. Removing..."

This comment has been minimized.

Copy link
@parente

parente Dec 12, 2016

Collaborator

Nit: should this be a warn? Feels like an possible important indicator that something might be amiss if we have a package that upstream never had or not longer has.

except tarfile.TarError:
logging.debug("tarfile error encountered. Original error below.")
logging.debug(pformat(traceback.format_exc()))
logging.info("Removing package: %s", filename)

This comment has been minimized.

Copy link
@parente

parente Dec 12, 2016

Collaborator

Nit: Maybe use warn level? A corrupted tarball might indicate a bigger problem we need to investigate.

This comment has been minimized.

Copy link
@ericdill

ericdill Dec 12, 2016

Author Contributor

corrupted tarball is more frequently a "connection interrupted" issue during download than anything else

pformat(os.listdir(download_dir)))
for f in os.listdir(download_dir):

if f.endswith('json') or f.endswith('.bz2'):

This comment has been minimized.

Copy link
@parente

parente Dec 12, 2016

Collaborator

Maybe I'm wrong, but I expect most changes to be addition of new packages rather than updates. In that case, it seems that moving all of the packages into place and then the JSON file would reduce the window of time when a user might do a conda install foo and get an error about a missing package because it hasn't been copied into place yet.

@parente parente merged commit 954eb80 into Valassis-Digital-Media:master Dec 12, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill deleted the ericdill:dont-use-conda-index branch Dec 12, 2016
@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Dec 12, 2016

Thanks @parente

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.