Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type Error #30

Merged
merged 3 commits into from Feb 23, 2017

Conversation

@ericdill
Copy link
Contributor

ericdill commented Feb 22, 2017

Closes #29

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 22, 2017

Codecov Report

Merging #30 into master will decrease coverage by -1.83%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   96.77%   94.95%   -1.83%     
==========================================
  Files           2        2              
  Lines         217      218       +1     
==========================================
- Hits          210      207       -3     
- Misses          7       11       +4
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 94.88% <100%> (-1.85%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072683b...676b4e5. Read the comment docs.

@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Feb 22, 2017

code review please @marshall245 @parente

@@ -93,30 +97,11 @@ def test_cli(tmpdir, channel, platform, repodata):
assert len(rd['info']) == len(disk_info)
assert len(rd['packages']) == len(disk_packages)


def test_handling_bad_package(tmpdir, repodata):

This comment has been minimized.

Copy link
@parente

parente Feb 22, 2017

Collaborator

Do the assertions in the test that calls this new function cover the purpose of the assertions in the removed test_handling_bad_package?

This comment has been minimized.

Copy link
@ericdill

ericdill Feb 23, 2017

Author Contributor

Not entirely. Will fix that in a new commit

This comment has been minimized.

Copy link
@ericdill

ericdill Feb 23, 2017

Author Contributor

Alright updated. Final check @parente ?

# https://github.com/maxpoint/conda-mirror/issues/29
_write_bad_package(channel_dir=f2.strpath, platform_name=platform,
pkg_name='bad-1-0.tar.bz2')
# Write a bad package that does exist in the upstreap repodata into the mirror path

This comment has been minimized.

Copy link
@parente

parente Feb 23, 2017

Collaborator

upstreap -> upstream

This comment has been minimized.

Copy link
@parente

parente Feb 23, 2017

Collaborator

One typo above. Then :shipit:

This comment has been minimized.

Copy link
@ericdill

ericdill Feb 23, 2017

Author Contributor

Good catch. Thanks @parente

@ericdill ericdill merged commit 676b4e5 into Valassis-Digital-Media:master Feb 23, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 96.77%)
Details
codecov/project Absolute coverage decreased by -1.82% but relative coverage increased by +3.22% compared to 072683b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill deleted the ericdill:fix-type-error branch Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.