Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix broken test #46

Merged
merged 1 commit into from Apr 13, 2017

Conversation

@ericdill
Copy link
Contributor

ericdill commented Apr 13, 2017

Couldn't figure out why this test was intermittently failing. Turns out that the top level keys of the repodata dict were conda-forge and https://repo.continuum.io/pkgs/free. Fun fact: dictionaries in python 3 do not have deterministic ordering, so when I was doing next(iter(repodata.keys())) I would be getting conda-forge or https://repo.continuum.io/pkgs/free in an effectively random fashion. If I was unlucky and got https://repo.continuum.io/pkgs/free, then the tests would fail because pytest was trying to write to a very deeply nested folder:

 '/tmp/pytest-of-p-edill/pytest-10/test_cli_conda_forge_linux_64_0/conda-forge/linux-64/https://repo.continuum.io/pkgs/free'

Also, the colon in the file path probably wasn't helping matters...

In any event, that was not the desired behavior. What I really wanted to get were the package names in that repodata dictionary which requires the change in this PR

@ericdill ericdill changed the title TST: Need to pull out the actual package name TST: Fix broken test Apr 13, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 13, 2017

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          206      206           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8159290...68e40e4. Read the comment docs.

@parente

This comment has been minimized.

Copy link
Collaborator

parente commented Apr 13, 2017

Nice catch.

@parente parente merged commit f352883 into Valassis-Digital-Media:master Apr 13, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 8159290...68e40e4
Details
codecov/project 94.06% remains the same compared to 8159290
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill deleted the ericdill:fix-failing-test branch Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.